Repository navigation
refactor: download core.sh from xhandler-rust instead of keeping a copy - #8
Merged
carlosthe19916 merged 1 commit intoNov 15, 2026
Conversation
hack/core.sh was a copy of the script that syncs and verifies a released core, identical in the three libraries only by convention. It now lives in xhandler-rust (xhandler-wasm/core.sh), next to the release format it reads; make sync CORE=, make verify-core and make verify-release download it from the tag of the core at hand (from main for an older or unreleased core) into a temporary file and run it. CORE_SH=<path> runs a local copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hack/core.shwas a copy of the script that syncs and verifies a released core, identical in the three libraries only by convention. It now lives in xhandler-rust asxhandler-wasm/core.sh(project-openubl/xhandler-rust#609), next to the release format it reads, and xhandler-rust tests it in CI.make sync CORE=,make verify-coreandmake verify-releasedownload it from the tag of the core at hand, falling back to xhandler-rust'smainfor an older or unreleased core. It's saved to a temporary file and then run, never piped intobash, so a dropped connection can't run half a script.CORE_SH=<path>runs a local copy, for example while changing it in xhandler-rust.hack/core.sh. CONTRIBUTING.md explains the above.Merge xhandler-rust#609 first, then re-run this PR's CI. Until then, the script is not on xhandler-rust's
main.Tested against a local server playing GitHub raw and releases: sync and verify-release use the tag's script, an unreleased core falls back to
mainand only warns,CORE_SHworks, and an unreachable script URL fails.🤖 Generated with Claude Code